diqiu50 commented on code in PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#discussion_r1774594485


##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java:
##########
@@ -126,20 +120,12 @@ public GravitinoTable createTable(ConnectorTableMetadata 
tableMetadata) {
         new GravitinoTable(schemaName, tableName, columns, comment, 
properties);
 
     if (!partitionColumns.isEmpty()) {
-      Transform[] partitioning =
-          
partitionColumns.stream().map(Transforms::identity).toArray(Transform[]::new);
+      Transform[] partitioning = 
ExpressionUtil.partitionFiledToExpression(partitionColumns);

Review Comment:
   Do you mean the function name or the parameter name.
   if it's the function name . I think the name is meaningful . Actually, it 
transforms the partition field into an expression



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to