mchades commented on code in PR #5013:
URL: https://github.com/apache/gravitino/pull/5013#discussion_r1776649647
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/operation/JdbcDatabaseOperations.java:
##########
@@ -129,4 +137,13 @@ protected Connection getConnection() throws SQLException {
protected boolean isSystemDatabase(String dbName) {
return false;
}
+
+ /**
+ * Check whether support setting schema comment.
+ *
+ * @return true for all cases.
+ */
+ protected boolean supportSchemaComment() {
Review Comment:
This should be abstract
##########
catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseDatabaseOperations.java:
##########
@@ -44,22 +52,65 @@ private static Set<String>
createSysOceanBaseDatabaseNames() {
@Override
public String generateCreateDatabaseSql(
Review Comment:
we can make this method as parent's default implementation for mysql and
oceanbase reusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
