jerqi commented on code in PR #5023:
URL: https://github.com/apache/gravitino/pull/5023#discussion_r1778068870


##########
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java:
##########
@@ -109,35 +94,18 @@ public List<RoleEntity> 
listRolesByMetadataObjectIdentAndType(
                     metadataObjectId, metadataObject.type().name()));
     return rolePOs.stream()
         .map(
-            po ->
-                POConverters.fromRolePO(
-                    po, listSecurableObjects(po), 
AuthorizationUtils.ofRoleNamespace(metalake)))
+            po -> {
+              if (allFields) {

Review Comment:
   This is used for internal implement. I used it in the FutureGrantManager, I 
need find all the roles contains metalake metadata object.  For example, I find 
the role contains `CREATE TABLE` for a metalake and apply the role for newly 
created catalog.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to