jerryshao commented on code in PR #5021:
URL: https://github.com/apache/gravitino/pull/5021#discussion_r1778422330
##########
core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java:
##########
@@ -373,11 +376,174 @@ User revokeRolesFromUser(String metalake, List<String>
roles, String user) {
}
}
- private List<String> toRoleNames(List<RoleEntity> roleEntities) {
- return
roleEntities.stream().map(RoleEntity::name).collect(Collectors.toList());
+ Role grantPrivilegeToRole(
+ String metalake, String role, MetadataObject object, List<Privilege>
privileges) {
Review Comment:
I think you need to check if these privileges can be bound to this metadata
object before you update the role.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
