jerqi commented on code in PR #5035:
URL: https://github.com/apache/gravitino/pull/5035#discussion_r1778573790
##########
docs/security/access-control.md:
##########
@@ -507,6 +620,91 @@ boolean deleted =
## Permission Operation
+### Grant privileges to a role
+
+You can revoke specific privileges from a role.
+The request path for REST API is
`/api/metalakes/{metalake}/permissions/roles/{role}/{metadataObjectType}/{metadataObjectName}/revoke`.
+
+<Tabs groupId='language' queryString>
+<TabItem value="shell" label="Shell">
+
+```shell
+curl -X PUT -H "Accept: application/vnd.gravitino.v1+json" \
+-H "Content-Type: application/json" -d '{
+ "privileges": [
+ {
+ "name": "SELECT_TABLE",
+ "condition": "ALLOW"
+ }]
+}'
http://localhost:8090/api/metalakes/test/permissions/roles/role1/schema/catalog1.schema1/revoke
+
+curl -X PUT -H "Accept: application/vnd.gravitino.v1+json" \
+-H "Content-Type: application/json" -d '{
+ "privileges": [
+ {
+ "name": "SELECT_TABLE",
+ "condition": "ALLOW"
+ }]
+}'
http://localhost:8090/api/metalakes/test/permissions/roles/role1/table/catalog1.schema1.table1/revoke
+```
+
+</TabItem>
+<TabItem value="java" label="Java">
+
+```java
+GravitinoClient client = ...
+
+MetadataObject schema = ...
+Role role = client.grantPrivilegesToRole("role1", schema,
Lists.newArrayList(Privileges.SelectTable.allow()));
+
+MetadataObject table = ...
+Role role = client.grantPrivilegesToRole("role1", table,
Lists.newArrayList(Privileges.SelectTable.allow()));
+```
+
+
+### Revoke privileges from a role
+
+You can revoke specific privileges from a role.
+The request path for REST API is
`/api/metalakes/{metalake}/permissions/roles/{role}/{metadataObjectType}/{metadataObjectName}/revoke`.
+
+<Tabs groupId='language' queryString>
+<TabItem value="shell" label="Shell">
+
+```shell
+curl -X PUT -H "Accept: application/vnd.gravitino.v1+json" \
+-H "Content-Type: application/json" -d '{
+ "privileges": [
+ {
+ "name": "SELECT_TABLE",
+ "condition": "ALLOW"
+ }]
+}'
http://localhost:8090/api/metalakes/test/permissions/roles/role1/schema/catalog1.schema1/grant
+
+curl -X PUT -H "Accept: application/vnd.gravitino.v1+json" \
+-H "Content-Type: application/json" -d '{
+ "privileges": [
+ {
+ "name": "SELECT_TABLE",
+ "condition": "ALLOW"
+ }]
+}'
http://localhost:8090/api/metalakes/test/permissions/roles/role1/table/catalog1.schema1.table1/grant
+```
+
+</TabItem>
+<TabItem value="java" label="Java">
+
+```java
+GravitinoClient client = ...
+
+MetadataObject schema = ...
+Role role = client.revokePrivilegesFromRole("role1", schema,
Lists.newArrayList(Privileges.SelectTable.allow()));
+
+MetadataObject table = ...
+Role role = client.revokePrivilegesFromRole("role1", table,
Lists.newArrayList(Privileges.SelectTable.allow()));
+
+```
+
+
Review Comment:
Removed.
##########
docs/security/access-control.md:
##########
@@ -507,6 +620,91 @@ boolean deleted =
## Permission Operation
+### Grant privileges to a role
+
+You can revoke specific privileges from a role.
+The request path for REST API is
`/api/metalakes/{metalake}/permissions/roles/{role}/{metadataObjectType}/{metadataObjectName}/revoke`.
+
+<Tabs groupId='language' queryString>
+<TabItem value="shell" label="Shell">
+
+```shell
+curl -X PUT -H "Accept: application/vnd.gravitino.v1+json" \
+-H "Content-Type: application/json" -d '{
+ "privileges": [
+ {
+ "name": "SELECT_TABLE",
+ "condition": "ALLOW"
+ }]
+}'
http://localhost:8090/api/metalakes/test/permissions/roles/role1/schema/catalog1.schema1/revoke
+
+curl -X PUT -H "Accept: application/vnd.gravitino.v1+json" \
+-H "Content-Type: application/json" -d '{
+ "privileges": [
+ {
+ "name": "SELECT_TABLE",
+ "condition": "ALLOW"
+ }]
+}'
http://localhost:8090/api/metalakes/test/permissions/roles/role1/table/catalog1.schema1.table1/revoke
+```
+
+</TabItem>
+<TabItem value="java" label="Java">
+
+```java
+GravitinoClient client = ...
+
+MetadataObject schema = ...
+Role role = client.grantPrivilegesToRole("role1", schema,
Lists.newArrayList(Privileges.SelectTable.allow()));
+
+MetadataObject table = ...
+Role role = client.grantPrivilegesToRole("role1", table,
Lists.newArrayList(Privileges.SelectTable.allow()));
+```
+
+
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
