jerqi commented on code in PR #5030:
URL: https://github.com/apache/gravitino/pull/5030#discussion_r1779891468
##########
clients/client-python/gravitino/filesystem/gvfs.py:
##########
@@ -362,11 +395,19 @@ def open(
:param kwargs: Extra args
:return A file-like object from the filesystem
"""
- context: FilesetContext = self._get_fileset_context(path)
- return context.get_fs().open(
- self._strip_storage_protocol(
- context.get_storage_type(), context.get_actual_path()
- ),
+ if mode.startswith("w"):
Review Comment:
What's the format of the mode? It could be `rw`?
##########
clients/client-python/gravitino/filesystem/gvfs.py:
##########
@@ -118,6 +104,31 @@ def __init__(
metalake_name=metalake_name,
auth_data_provider=SimpleAuthProvider(),
)
+ elif auth_type == GVFSConfig.OAUTH2_AUTH_TYPE:
Review Comment:
The code above should be `auth_type == GVFSConfig.SIMPLE_AUTH_TYPE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
