caican00 commented on code in PR #5092:
URL: https://github.com/apache/gravitino/pull/5092#discussion_r1796371483


##########
catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/integration/test/CatalogPaimonBaseIT.java:
##########
@@ -712,11 +727,11 @@ public void testAlterPaimonTable() {
     // update column position
     Column col1 = Column.of("name", Types.StringType.get(), "comment");
     Column col2 = Column.of("address", Types.StringType.get(), "comment");
-    Column col3 = Column.of("date_of_birth", Types.DateType.get(), "comment");

Review Comment:
   it will throw an exception about `InvalidOperationException(message:The 
following columns have types incompatible with the existing columns in their 
respective positions` for hive backend, and it is an issue of hms not 
lakehouse. and 
[hive.metastore.disallow.incompatible.col.type.changes](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=27842758#ConfigurationProperties-hive.metastore.disallow.incompatible.col.type.changes)
 is a server-side parameter of hms, we can't change this behavior based on the 
parameter. Therefor, i changed the column type here to ignore this problem.
   
   as shown below, hudi and iceberg both have this problem.
   https://github.com/apache/hudi/issues/2212
   https://github.com/apache/iceberg/issues/1092



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to