xloya commented on code in PR #5078:
URL: https://github.com/apache/gravitino/pull/5078#discussion_r1796583051
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/MetalakeMetaService.java:
##########
@@ -191,6 +192,10 @@ public boolean deleteMetalake(NameIdentifier ident,
boolean cascade) {
SessionUtils.doWithoutCommit(
TableMetaMapper.class,
mapper ->
mapper.softDeleteTableMetasByMetalakeId(metalakeId)),
+ () ->
+ SessionUtils.doWithoutCommit(
Review Comment:
I think it's also need add the recursive delete logic in
`CatalogMetaService`, `SchemaMetaService`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
