yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1798822283
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##########
@@ -742,4 +769,51 @@ private boolean checkSingleFile(Fileset fileset) {
fileset.name());
}
}
+
+ static FileSystem getFileSystem(Path path, Map<String, String> config)
throws IOException {
+ Map<String, String> newConfig = Maps.newHashMap(config);
+ String scheme;
+ Path fsPath;
+ if (path != null) {
+ scheme = path.toUri().getScheme();
+ if (scheme == null) {
+ // If the schema of the path is not set, we need to get the default FS
from the
+ // configuration.
+ String defaultFS = config.get(DEFAULT_FS);
Review Comment:
> If this is a catalog property should be defined by users, why can't you
follow our rule to define the key name and manage them in property metadata?
What's the `users` you refer to? As I have said, `DEFAULT_FS` is NOT a
necessary property for ordinary users, for any developer, it's a required one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
