jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798876861
##########
common/build.gradle.kts:
##########
@@ -28,6 +28,7 @@ plugins {
dependencies {
implementation(project(":api"))
+ implementation(project(":catalogs:catalog-common"))
Review Comment:
No, it's weird to make common module rely on catalog-common module, which
have different propose and easy to introduce cyclic dependency, please change
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
