mchades commented on code in PR #5067:
URL: https://github.com/apache/gravitino/pull/5067#discussion_r1804199838
##########
clients/client-python/gravitino/client/gravitino_metalake.py:
##########
@@ -185,19 +185,47 @@ def alter_catalog(self, name: str, *changes:
CatalogChange) -> Catalog:
self.name(), catalog_response.catalog(), self.rest_client
)
- def drop_catalog(self, name: str) -> bool:
+ def drop_catalog(self, name: str, force: bool = False) -> bool:
"""Drop the catalog with specified name.
Args:
- name the name of the catalog.
+ name: the name of the catalog.
+ force: whether to force drop the catalog.
Returns:
- true if the catalog is dropped successfully, false otherwise.
+ true if the catalog is dropped successfully, false if the catalog
does not exist.
"""
+ params = {"force": str(force)}
Review Comment:
In any case, the server side will ignore case sensitivity during query param
conversion. So it's not a problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
