jerqi commented on code in PR #5040:
URL: https://github.com/apache/gravitino/pull/5040#discussion_r1804727827
##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/catalog/GravitinoCatalogManager.java:
##########
@@ -37,22 +37,18 @@ public class GravitinoCatalogManager {
private volatile boolean isClosed = false;
private final Cache<String, Catalog> gravitinoCatalogs;
- private final String metalakeName;
- private final GravitinoMetalake metalake;
- private final GravitinoAdminClient gravitinoClient;
+ private final GravitinoClient gravitinoClient;
- private GravitinoCatalogManager(String gravitinoUri, String metalakeName) {
- this.metalakeName = metalakeName;
- this.gravitinoClient = GravitinoAdminClient.builder(gravitinoUri).build();
+ private GravitinoCatalogManager(Supplier<GravitinoClient> clientBuilder) {
+ this.gravitinoClient = clientBuilder.get();
// Will not evict catalog by default
this.gravitinoCatalogs = CacheBuilder.newBuilder().build();
- this.metalake = gravitinoClient.loadMetalake(metalakeName);
}
- public static GravitinoCatalogManager create(String gravitinoUrl, String
metalakeName) {
+ public static GravitinoCatalogManager create(Supplier<GravitinoClient>
clientBuilder) {
Preconditions.checkState(
gravitinoCatalogManager == null, "Should not create duplicate
GravitinoCatalogManager");
- gravitinoCatalogManager = new GravitinoCatalogManager(gravitinoUrl,
metalakeName);
+ gravitinoCatalogManager = new GravitinoCatalogManager(clientBuilder);
Review Comment:
Client can't a field. Otherwise, the client won't support
UserGroupInformation.doAs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
