jerryshao commented on code in PR #5134:
URL: https://github.com/apache/gravitino/pull/5134#discussion_r1806023500
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -162,12 +186,25 @@ public Response loadTable(
@PathParam("prefix") String prefix,
@PathParam("namespace") String namespace,
@PathParam("table") String table,
- @DefaultValue("all") @QueryParam("snapshots") String snapshots) {
+ @DefaultValue("all") @QueryParam("snapshots") String snapshots,
+ @HeaderParam(X_ICEBERG_ACCESS_DELEGATION) String accessDelegation) {
+ boolean isCredentialVending = isCredentialVending(accessDelegation);
+ LOG.info(
+ "Load iceberg table, namespace: {}, table: {}, accessDelegation: {},
is credential vending: {}",
Review Comment:
`access deletation: {}...`
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -162,12 +186,25 @@ public Response loadTable(
@PathParam("prefix") String prefix,
@PathParam("namespace") String namespace,
@PathParam("table") String table,
- @DefaultValue("all") @QueryParam("snapshots") String snapshots) {
+ @DefaultValue("all") @QueryParam("snapshots") String snapshots,
+ @HeaderParam(X_ICEBERG_ACCESS_DELEGATION) String accessDelegation) {
+ boolean isCredentialVending = isCredentialVending(accessDelegation);
+ LOG.info(
+ "Load iceberg table, namespace: {}, table: {}, accessDelegation: {},
is credential vending: {}",
Review Comment:
`access delegation: {}...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
