mchades commented on code in PR #5155:
URL: https://github.com/apache/gravitino/pull/5155#discussion_r1808252995
##########
api/src/main/java/org/apache/gravitino/SupportsMetalakes.java:
##########
@@ -86,10 +89,69 @@ Metalake alterMetalake(String name, MetalakeChange...
changes)
throws NoSuchMetalakeException, IllegalArgumentException;
/**
- * Drop a metalake with specified identifier.
+ * Drop a metalake with specified name. Please make sure:
*
- * @param name The identifier of the metalake.
+ * <ul>
+ * <li>There is no catalog in the metalake. Otherwise, a {@link
NonEmptyEntityException} will be
+ * thrown.
+ * <li>The method {@link #disableMetalake(String)} has been called before
dropping the metalake.
+ * Otherwise, a {@link MetalakeInUseException} will be thrown.
+ * </ul>
+ *
+ * It is equivalent to calling {@code dropMetalake(ident, false)}.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
