jerryshao commented on PR #5058: URL: https://github.com/apache/gravitino/pull/5058#issuecomment-2425893593
>I hope it be: > >export GRAVITINO_METALAKE=metalake_demo >gcli metalake list >gcli catalog list --name catalog_iceberg >gcli schema list --name catalog.schema I would suggest that we either using env variable or a specify argument like `--metalake` to specify the metalake name, we'd better not fix it into the entity name. Overall, I like @shaofengshi 's suggestion, this will make the command more consistent and user-friendly. Besides, as I also mentioned before: 1. the docs should be in `docs` folder, not put it here under cli, and make it render-able for Docusaurus, not a simple README. 2. The script should be put in `bin`, not under cli, also, the script should be workable, user can use the script to run the command simply, not a fake script, which is not good. This PR is actually not ready to merge, we should clearly define the arguments as the first PR, otherwise we will have to refactor all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
