yuanoOo commented on code in PR #5182:
URL: https://github.com/apache/gravitino/pull/5182#discussion_r1809770965
##########
catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/converter/OceanBaseColumnDefaultValueConverter.java:
##########
Review Comment:
There are some differences with MySQL, mainly in these data types:
```
case OceanBaseTypeConverter.NUMBER:
case OceanBaseTypeConverter.NUMERIC:
case OceanBaseTypeConverter.DECIMAL:
return Literals.decimalLiteral(
Decimal.of(
columnDefaultValue,
Integer.parseInt(type.getColumnSize()),
Integer.parseInt(type.getScale())));
case OceanBaseTypeConverter.JSON:
case JdbcTypeConverter.TEXT:
return Literals.stringLiteral(columnDefaultValue);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
