FANNG1 commented on code in PR #5156:
URL: https://github.com/apache/gravitino/pull/5156#discussion_r1810508730
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -101,8 +102,12 @@ public IcebergTableOperations(
@ResponseMetered(name = "list-table", absolute = true)
public Response listTable(
@PathParam("prefix") String prefix, @PathParam("namespace") String
namespace) {
- return IcebergRestUtils.ok(
-
icebergCatalogWrapperManager.getOps(prefix).listTable(RESTUtil.decodeNamespace(namespace)));
+ String catalogName = IcebergRestUtils.getCatalogName(prefix);
+ Namespace icebergNS = RESTUtil.decodeNamespace(namespace);
+ LOG.info("List Iceberg tables, catalog:{}, namespace: {}", catalogName,
icebergNS);
Review Comment:
updated
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -195,21 +199,23 @@ public Response loadTable(
@PathParam("table") String table,
@DefaultValue("all") @QueryParam("snapshots") String snapshots,
@HeaderParam(X_ICEBERG_ACCESS_DELEGATION) String accessDelegation) {
+ String catalogName = IcebergRestUtils.getCatalogName(prefix);
+ Namespace icebergNS = RESTUtil.decodeNamespace(namespace);
boolean isCredentialVending = isCredentialVending(accessDelegation);
LOG.info(
- "Load iceberg table, namespace: {}, table: {}, access delegation: {}, "
+ "Load iceberg table, catalog: {}, namespace: {}, table: {}, access
delegation: {}, "
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
