jerryshao commented on code in PR #5222:
URL: https://github.com/apache/gravitino/pull/5222#discussion_r1810676453


##########
api/src/main/java/org/apache/gravitino/MetadataObjects.java:
##########
@@ -159,7 +160,7 @@ public static MetadataObject parse(String fullName, 
MetadataObject.Type type) {
    * @param names The names of the metadata object
    * @return The parent full name if it exists, otherwise null
    */
-  public static String getParentFullName(List<String> names) {
+  private static String getParentFullName(List<String> names) {

Review Comment:
   It is better not to change the scope from public to private, this will break 
the compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to