jerryshao commented on PR #5058: URL: https://github.com/apache/gravitino/pull/5058#issuecomment-2429297198
> Hi Justin, my comments are all resolved now, thank you! > > I see you have replied Jerry's comments; I think he suggests to move the document to gravitino project's "docs" folder (not in cli module) and make its style consistent with others; besides, the error.sh and example.sh are sample commands, not for execution, which can be a part of documentation? You'd better double confirm with him. Yes, docs should be in the "docs" folder, and it is user-facing doc, also any other content like test/contribute is not necessary to add. Besides, these two shell scripts are just for demo purposes, it is not so useful and can be covered by doc, I suggest that you remove these two scripts here. You can add a script for running cli easily, like "gravitino.sh", for example "gcli.sh", this can be done in the later PR, but it should be in the "bin" folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
