yuqi1129 commented on code in PR #5244:
URL: https://github.com/apache/gravitino/pull/5244#discussion_r1815957219
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/storage/S3Properties.java:
##########
@@ -31,5 +31,8 @@ public class S3Properties {
// The region of the S3 service.
public static final String GRAVITINO_S3_REGION = "s3-region";
+ // The S3 credentials provider class name.
+ public static final String GRAVITINO_S3_CREDS_PROVIDER = "s3-creds-provider";
+
private S3Properties() {}
}
Review Comment:
The default value of this key is `EC2ContainerCredentialsProviderWrapper`
which is NOT `BasicAWSCredentialsProvider` for S3, however, the corresponding
value for `OSS` is the one that uses AS/SK, so we do not need to add this one.
Another problem, we use
the key `s3-creds-provider` in Gravitino server and use `s3.creds.providers`
for GVFS, is that OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
