jerqi commented on code in PR #5136: URL: https://github.com/apache/gravitino/pull/5136#discussion_r1818703832
########## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/authentication/kerberos/HiveBackendProxy.java: ########## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.catalog.lakehouse.paimon.authentication.kerberos; + +import java.io.IOException; +import java.lang.reflect.Field; +import java.lang.reflect.Method; +import java.security.PrivilegedExceptionAction; +import net.sf.cglib.proxy.Enhancer; +import net.sf.cglib.proxy.MethodInterceptor; +import net.sf.cglib.proxy.MethodProxy; +import org.apache.gravitino.catalog.lakehouse.paimon.utils.PaimonHiveCachedClientPool; +import org.apache.gravitino.utils.PrincipalUtils; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.IMetaStoreClient; +import org.apache.hadoop.hive.thrift.DelegationTokenIdentifier; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.security.token.Token; +import org.apache.paimon.client.ClientPool; +import org.apache.paimon.hive.HiveCatalog; +import org.apache.paimon.hive.HiveCatalogFactory; +import org.apache.paimon.options.Options; +import org.apache.thrift.TException; + +/** + * Proxy class for HiveCatalog to support kerberos authentication. We can also make HiveCatalog as a + * generic type and pass it as a parameter to the constructor. + */ +public class HiveBackendProxy implements MethodInterceptor { + + private final HiveCatalog target; + private final Class<? extends HiveCatalog> targetClazz; + private final String kerberosRealm; + private final UserGroupInformation proxyUser; + private final Options options; + private final ClientPool<IMetaStoreClient, TException> newClientPool; + + public HiveBackendProxy(Options options, HiveCatalog target, String kerberosRealm) { + this.target = target; + targetClazz = target.getClass(); + this.options = options; + this.kerberosRealm = kerberosRealm; + try { + proxyUser = UserGroupInformation.getCurrentUser(); + + // Replace the original client pool with PaimonHiveCachedClientPool. Why do we need to do + // this? Because the original client pool in Paimon uses a fixed username to create the + // client pool, and it will not work with kerberos authentication. We need to create a new + // client pool with the current user. For more, please see CachedClientPool#clientPool and + // notice the value of `key` + this.newClientPool = resetPaimonHiveCachedClientPool(); + } catch (IOException e) { + throw new RuntimeException("Failed to get current user", e); + } catch (IllegalAccessException | NoSuchFieldException e) { + throw new RuntimeException("Failed to reset PaimonHiveCachedClientPool", e); + } + } + + @Override + public Object intercept(Object o, Method method, Object[] objects, MethodProxy methodProxy) + throws Throwable { + + String proxyKerberosPrincipalName = PrincipalUtils.getCurrentPrincipal().getName(); + if (!proxyKerberosPrincipalName.contains("@")) { + proxyKerberosPrincipalName = + String.format("%s@%s", proxyKerberosPrincipalName, kerberosRealm); + } + + UserGroupInformation realUser = + UserGroupInformation.createProxyUser(proxyKerberosPrincipalName, proxyUser); + + String token = + newClientPool.run( + client -> + client.getDelegationToken( + PrincipalUtils.getCurrentPrincipal().getName(), proxyUser.getShortUserName())); + + Token<DelegationTokenIdentifier> delegationToken = new Token<>(); + delegationToken.decodeFromUrlString(token); + realUser.addToken(delegationToken); + + return realUser.doAs( + (PrivilegedExceptionAction<Object>) + () -> { + try { + return methodProxy.invoke(target, objects); + } catch (Throwable e) { + if (RuntimeException.class.isAssignableFrom(e.getClass())) { + throw (RuntimeException) e; + } + throw new RuntimeException("Failed to invoke method", e); + } + }); + } + + private ClientPool<IMetaStoreClient, TException> resetPaimonHiveCachedClientPool() + throws IllegalAccessException, NoSuchFieldException { + final Field m = HiveCatalog.class.getDeclaredField("clients"); Review Comment: HiveCatalog‘s clients field may have alive threads. Do you need to close them first? cc @yuqi1129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
