yuanoOo commented on code in PR #5272:
URL: https://github.com/apache/gravitino/pull/5272#discussion_r1820001048
##########
web/web/src/lib/utils/initial.js:
##########
@@ -308,5 +308,33 @@ export const providers = [
description: 'Apache Hudi catalog uri config'
}
]
+ },
+ {
+ label: 'OceanBase',
+ value: 'jdbc-oceanbase',
+ defaultProps: [
+ {
+ key: 'jdbc-driver',
+ value: '',
+ required: true,
+ description: 'e.g. com.mysql.jdbc.Driver or com.mysql.cj.jdbc.Driver'
+ },
+ {
+ key: 'jdbc-url',
+ value: '',
+ required: true,
+ description: 'e.g. jdbc:mysql://localhost:2881'
Review Comment:
```suggestion
description: 'e.g. jdbc:mysql://localhost:2881' or
jdbc:oceanbase://localhost:2881'
```
##########
web/web/src/lib/utils/initial.js:
##########
@@ -308,5 +308,33 @@ export const providers = [
description: 'Apache Hudi catalog uri config'
}
]
+ },
+ {
+ label: 'OceanBase',
+ value: 'jdbc-oceanbase',
+ defaultProps: [
+ {
+ key: 'jdbc-driver',
+ value: '',
+ required: true,
+ description: 'e.g. com.mysql.jdbc.Driver or com.mysql.cj.jdbc.Driver'
Review Comment:
`com.oceanbase.jdbc.Driver` is also available for OceanBase.
```suggestion
description: 'e.g. com.mysql.jdbc.Driver or
com.mysql.cj.jdbc.Driver' or `com.oceanbase.jdbc.Driver`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
