yuqi1129 commented on code in PR #5244:
URL: https://github.com/apache/gravitino/pull/5244#discussion_r1820473016
##########
catalogs/catalog-hadoop/src/test/java/org/apache/gravitino/catalog/hadoop/integration/test/HadoopGCSCatalogIT.java:
##########
@@ -107,4 +112,64 @@ protected void createCatalog() {
protected String generateLocation(String filesetName) {
return String.format("%s/%s", defaultBaseLocation, filesetName);
}
+
+ @Test
+ public void testCreateSchemaAndFilesetWithSpecialLocation() {
Review Comment:
This is to fix the bug introduced by #5296, we need to consider other Hadoop
catalog like S3, OSS and GCS.
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystemConfiguration.java:
##########
@@ -107,5 +112,46 @@ public class GravitinoVirtualFileSystemConfiguration {
public static final long
FS_GRAVITINO_FILESET_CACHE_EVICTION_MILLS_AFTER_ACCESS_DEFAULT =
1000L * 60 * 60;
+ private static final Map<String, String> GVFS_S3_KEY_TO_HADOOP_KEY =
Review Comment:
In the long run, we can provide a method like `requiredPropertyKey` in the
`FileSystemProvider` and load this provider by service provider. By doing so,
we can register this property to the client dynamically. Currently, we cannot
avoid this hard coding.
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemProvider.java:
##########
@@ -32,6 +32,8 @@
*/
public interface FileSystemProvider {
+ String GRAVITINO_BYPASS = "gravitino.bypass.";
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
