jerryshao commented on code in PR #5314: URL: https://github.com/apache/gravitino/pull/5314#discussion_r1820652666
########## docs/iceberg-rest-service.md: ########## @@ -371,7 +371,7 @@ For example, we can configure Spark catalog options to use Gravitino Iceberg RES --conf spark.sql.catalog.rest.uri=http://127.0.0.1:9001/iceberg/ ``` -You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark, no extra config is needed if you enable credential vending in the server side by setting `credential-provider-type` and enable credential vending request in client side by setting `spark.sql.catalog.rest.header.X-Iceberg-Access-Delegation` = `vended-credentials`. +You may need to adjust the Iceberg Spark runtime jar file name according to the real version number in your environment. If you want to access the data stored in cloud, you need to download corresponding jars (please refer to the cloud storage part) and place it in the classpath of Spark. If you want to enable credential vending, please setting `credential-provider-type` to proper value in server side, setting `spark.sql.catalog.rest.header.X-Iceberg-Access-Delegation` = `vended-credentials` in client side. Review Comment: There are "two" whitespaces before "please", please remove one. "please set xxx to a proper value in the server side, set xxx in the client side." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
