jerryshao commented on code in PR #5324:
URL: https://github.com/apache/gravitino/pull/5324#discussion_r1822087249


##########
docs/how-to-use-gvfs.md:
##########
@@ -49,22 +49,69 @@ the path mapping and convert automatically.
 
 ### Configuration
 
-| Configuration item                                    | Description          
                                                                                
                                                                                
                    | Default value | Required                            | 
Since version |
-|-------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|-------------------------------------|---------------|
-| `fs.AbstractFileSystem.gvfs.impl`                     | The Gravitino 
Virtual File System abstract class, set it to 
`org.apache.gravitino.filesystem.hadoop.Gvfs`.                                  
                                                             | (none)        | 
Yes                                 | 0.5.0         |
-| `fs.gvfs.impl`                                        | The Gravitino 
Virtual File System implementation class, set it to 
`org.apache.gravitino.filesystem.hadoop.GravitinoVirtualFileSystem`.            
                                                       | (none)        | Yes    
                             | 0.5.0         |
-| `fs.gvfs.impl.disable.cache`                          | Disable the 
Gravitino Virtual File System cache in the Hadoop environment. If you need to 
proxy multi-user operations, please set this value to `true` and create a 
separate File System for each user.  | `false`       | No                       
           | 0.5.0         |
-| `fs.gravitino.server.uri`                             | The Gravitino server 
URI which GVFS needs to load the fileset metadata.                              
                                                                                
                    | (none)        | Yes                                 | 
0.5.0         |
-| `fs.gravitino.client.metalake`                        | The metalake to 
which the fileset belongs.                                                      
                                                                                
                         | (none)        | Yes                                 
| 0.5.0         |
-| `fs.gravitino.client.authType`                        | The auth type to 
initialize the Gravitino client to use with the Gravitino Virtual File System. 
Currently only supports `simple`, `oauth2` and `kerberos` auth types.           
                         | `simple`      | No                                  
| 0.5.0         |
-| `fs.gravitino.client.oauth2.serverUri`                | The auth server URI 
for the Gravitino client when using `oauth2` auth type with the Gravitino 
Virtual File System.                                                            
                           | (none)        | Yes if you use `oauth2` auth type  
 | 0.5.0         |
-| `fs.gravitino.client.oauth2.credential`               | The auth credential 
for the Gravitino client when using `oauth2` auth type in the Gravitino Virtual 
File System.                                                                    
                     | (none)        | Yes if you use `oauth2` auth type   | 
0.5.0         |
-| `fs.gravitino.client.oauth2.path`                     | The auth server path 
for the Gravitino client when using `oauth2` auth type with the Gravitino 
Virtual File System. Please remove the first slash `/` from the path, for 
example `oauth/token`.          | (none)        | Yes if you use `oauth2` auth 
type   | 0.5.0         |
-| `fs.gravitino.client.oauth2.scope`                    | The auth scope for 
the Gravitino client when using `oauth2` auth type with the Gravitino Virtual 
File System.                                                                    
                        | (none)        | Yes if you use `oauth2` auth type   | 
0.5.0         |
-| `fs.gravitino.client.kerberos.principal`              | The auth principal 
for the Gravitino client when using `kerberos` auth type with the Gravitino 
Virtual File System.                                                            
                          | (none)        | Yes if you use `kerberos` auth type 
| 0.5.1         |
-| `fs.gravitino.client.kerberos.keytabFilePath`         | The auth keytab file 
path for the Gravitino client when using `kerberos` auth type in the Gravitino 
Virtual File System.                                                            
                     | (none)        | No                                  | 
0.5.1         |
-| `fs.gravitino.fileset.cache.maxCapacity`              | The cache capacity 
of the Gravitino Virtual File System.                                           
                                                                                
                      | `20`          | No                                  | 
0.5.0         |
-| `fs.gravitino.fileset.cache.evictionMillsAfterAccess` | The value of time 
that the cache expires after accessing in the Gravitino Virtual File System. 
The value is in `milliseconds`.                                                 
                          | `3600000`     | No                                  
| 0.5.0         |
+| Configuration item                                    | Description          
                                                                                
                                                                                
                   | Default value | Required                                   
                                                           | Since version    |
+|-------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|-------------------------------------------------------------------------------------------------------|------------------|
+| `fs.AbstractFileSystem.gvfs.impl`                     | The Gravitino 
Virtual File System abstract class, set it to 
`org.apache.gravitino.filesystem.hadoop.Gvfs`.                                  
                                                            | (none)        | 
Yes                                                                             
                      | 0.5.0            |
+| `fs.gvfs.impl`                                        | The Gravitino 
Virtual File System implementation class, set it to 
`org.apache.gravitino.filesystem.hadoop.GravitinoVirtualFileSystem`.            
                                                      | (none)        | Yes     
                                                                                
              | 0.5.0            |
+| `fs.gvfs.impl.disable.cache`                          | Disable the 
Gravitino Virtual File System cache in the Hadoop environment. If you need to 
proxy multi-user operations, please set this value to `true` and create a 
separate File System for each user. | `false`       | No                        
                                                                            | 
0.5.0            |
+| `fs.gravitino.server.uri`                             | The Gravitino server 
URI which GVFS needs to load the fileset metadata.                              
                                                                                
                   | (none)        | Yes                                        
                                                           | 0.5.0            |
+| `fs.gravitino.client.metalake`                        | The metalake to 
which the fileset belongs.                                                      
                                                                                
                        | (none)        | Yes                                   
                                                                | 0.5.0         
   |
+| `fs.gravitino.client.authType`                        | The auth type to 
initialize the Gravitino client to use with the Gravitino Virtual File System. 
Currently only supports `simple`, `oauth2` and `kerberos` auth types.           
                        | `simple`      | No                                    
                                                                | 0.5.0         
   |
+| `fs.gravitino.client.oauth2.serverUri`                | The auth server URI 
for the Gravitino client when using `oauth2` auth type with the Gravitino 
Virtual File System.                                                            
                          | (none)        | Yes if you use `oauth2` auth type   
                                                                  | 0.5.0       
     |
+| `fs.gravitino.client.oauth2.credential`               | The auth credential 
for the Gravitino client when using `oauth2` auth type in the Gravitino Virtual 
File System.                                                                    
                    | (none)        | Yes if you use `oauth2` auth type         
                                                            | 0.5.0            |
+| `fs.gravitino.client.oauth2.path`                     | The auth server path 
for the Gravitino client when using `oauth2` auth type with the Gravitino 
Virtual File System. Please remove the first slash `/` from the path, for 
example `oauth/token`.         | (none)        | Yes if you use `oauth2` auth 
type                                                                     | 
0.5.0            |
+| `fs.gravitino.client.oauth2.scope`                    | The auth scope for 
the Gravitino client when using `oauth2` auth type with the Gravitino Virtual 
File System.                                                                    
                       | (none)        | Yes if you use `oauth2` auth type      
                                                               | 0.5.0          
  |
+| `fs.gravitino.client.kerberos.principal`              | The auth principal 
for the Gravitino client when using `kerberos` auth type with the Gravitino 
Virtual File System.                                                            
                         | (none)        | Yes if you use `kerberos` auth type  
                                                                 | 0.5.1        
    |
+| `fs.gravitino.client.kerberos.keytabFilePath`         | The auth keytab file 
path for the Gravitino client when using `kerberos` auth type in the Gravitino 
Virtual File System.                                                            
                    | (none)        | No                                        
                                                            | 0.5.1            |
+| `fs.gravitino.fileset.cache.maxCapacity`              | The cache capacity 
of the Gravitino Virtual File System.                                           
                                                                                
                     | `20`          | No                                       
                                                             | 0.5.0            
|
+| `fs.gravitino.fileset.cache.evictionMillsAfterAccess` | The value of time 
that the cache expires after accessing in the Gravitino Virtual File System. 
The value is in `milliseconds`.                                                 
                         | `3600000`     | No                                   
                                                                 | 0.5.0        
    |
+| `fs.gravitino.fileset.cache.evictionMillsAfterAccess` | The value of time 
that the cache expires after accessing in the Gravitino Virtual File System. 
The value is in `milliseconds`.                                                 
                         | `3600000`     | No                                   
                                                                 | 0.5.0        
    |
+
+Apart from the above properties, to access fileset like S3, GCS, OSS or custom 
fileset through GVFS, you need to configure the following extra properties.
+
+#### S3 fileset
+
+| Configuration item             | Description                                 
                                                                                
                                                          | Default value | 
Required                  | Since version    |
+|--------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|---------------------------|------------------|
+| `fs.gvfs.filesystem.providers` | The file system providers to add. Set it to 
`s3` if it's a s3 fileset or a comma separated string that contains `s3` like 
`gs,s3` to support multiple kind of fileset including `s3`. | (none)        | 
Yes if it's a s3 fileset. | 0.7.0-incubating |
+| `s3-endpoint`                  | The endpoint of the AWS s3.                 
                                                                                
                                                          | (none)        | Yes 
if it's a s3 fileset. | 0.7.0-incubating |
+| `s3-access-key-id`             | The access key of the AWS s3.               
                                                                                
                                                          | (none)        | Yes 
if it's a s3 fileset. | 0.7.0-incubating |
+| `s3-secret-access-key`         | The secret key of the AWS s3.               
                                                                                
                                                          | (none)        | Yes 
if it's a s3 fileset. | 0.7.0-incubating |
+
+At the same time, you need to place the corresponding bundle jar 
[gravitino-aws-bundle-{version}.jar](https://repo1.maven.org/maven2/org/apache/gravitino/aws-bundle/)
 in the Hadoop environment.

Review Comment:
   You'd better give an example of how to use gvfs with s3 or gcs, not vaguely 
saying "in the Hadoop environment".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to