FANNG1 commented on code in PR #5176:
URL: https://github.com/apache/gravitino/pull/5176#discussion_r1821970430
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##########
@@ -657,20 +698,314 @@ private boolean doRemoveSecurableObject(
return true;
}
+ /**
+ * IF remove the SCHEMA, Need to remove these the relevant policies,
`{schema}`, `{schema}.*`,
+ * `{schema}.*.*` <br>
+ * IF remove the TABLE, Need to remove these the relevant policies,
`{schema}.*`, `{schema}.*.*`
Review Comment:
Need -> need
##########
api/src/main/java/org/apache/gravitino/authorization/MetadataObjectChange.java:
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.authorization;
+
+import com.google.common.base.Preconditions;
+import java.util.Objects;
+import org.apache.gravitino.MetadataObject;
+import org.apache.gravitino.annotation.Evolving;
+
+/**
+ * The MetadataObjectChange interface defines the public API for managing
roles in an authorization.
+ */
+@Evolving
+public interface MetadataObjectChange {
+ /**
+ * Rename a metadata entity MetadataObjectChange.
+ *
+ * @param metadataObject The metadata object.
+ * @param newMetadataObject The new metadata object.
+ * @return return a MetadataObjectChange for the rename metadata object.
+ */
+ static MetadataObjectChange rename(
+ MetadataObject metadataObject, MetadataObject newMetadataObject) {
+ return new RenameMetadataObject(metadataObject, newMetadataObject);
+ }
+
+ /**
+ * Remove a metadata entity MetadataObjectChange.
+ *
+ * @param metadataObject The metadata object.
+ * @return return a MetadataObjectChange for the remove metadata object.
+ */
+ static MetadataObjectChange remove(MetadataObject metadataObject) {
+ return new RemoveMetadataObject(metadataObject);
+ }
+
+ /** A RenameMetadataObject is to rename securable object's metadata entity.
*/
+ final class RenameMetadataObject implements MetadataObjectChange {
+ private final MetadataObject metadataObject;
+ private final MetadataObject newMetadataObject;
+
+ private RenameMetadataObject(MetadataObject metadataObject, MetadataObject
newMetadataObject) {
+ Preconditions.checkArgument(
+ !metadataObject.fullName().equals(newMetadataObject.fullName()),
+ "The metadata object must be different!");
+ Preconditions.checkArgument(
+ metadataObject.type().equals(newMetadataObject.type()),
+ "The metadata object type must be same!");
+
+ this.metadataObject = metadataObject;
+ this.newMetadataObject = newMetadataObject;
+ }
+
+ /**
+ * Returns the metadataObject to be renamed.
+ *
+ * @return return a metadataObject.
+ */
+ public MetadataObject getMetadataObject() {
Review Comment:
remove `get` from method name?
##########
api/src/main/java/org/apache/gravitino/authorization/MetadataObjectChange.java:
##########
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.authorization;
+
+import com.google.common.base.Preconditions;
+import java.util.Objects;
+import org.apache.gravitino.MetadataObject;
+import org.apache.gravitino.annotation.Evolving;
+
+/**
+ * The MetadataObjectChange interface defines the public API for managing
roles in an authorization.
+ */
+@Evolving
+public interface MetadataObjectChange {
+ /**
+ * Rename a metadata entity MetadataObjectChange.
+ *
+ * @param metadataObject The metadata object.
+ * @param newMetadataObject The new metadata object.
+ * @return return a MetadataObjectChange for the rename metadata object.
+ */
+ static MetadataObjectChange rename(
+ MetadataObject metadataObject, MetadataObject newMetadataObject) {
+ return new RenameMetadataObject(metadataObject, newMetadataObject);
+ }
+
+ /**
+ * Remove a metadata entity MetadataObjectChange.
+ *
+ * @param metadataObject The metadata object.
+ * @return return a MetadataObjectChange for the remove metadata object.
+ */
+ static MetadataObjectChange remove(MetadataObject metadataObject) {
+ return new RemoveMetadataObject(metadataObject);
+ }
+
+ /** A RenameMetadataObject is to rename securable object's metadata entity.
*/
+ final class RenameMetadataObject implements MetadataObjectChange {
+ private final MetadataObject metadataObject;
+ private final MetadataObject newMetadataObject;
+
+ private RenameMetadataObject(MetadataObject metadataObject, MetadataObject
newMetadataObject) {
+ Preconditions.checkArgument(
+ !metadataObject.fullName().equals(newMetadataObject.fullName()),
+ "The metadata object must be different!");
+ Preconditions.checkArgument(
+ metadataObject.type().equals(newMetadataObject.type()),
+ "The metadata object type must be same!");
+
+ this.metadataObject = metadataObject;
+ this.newMetadataObject = newMetadataObject;
+ }
+
+ /**
+ * Returns the metadataObject to be renamed.
+ *
+ * @return return a metadataObject.
+ */
+ public MetadataObject getMetadataObject() {
+ return this.metadataObject;
Review Comment:
please remove `this`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
