caican00 commented on code in PR #5376:
URL: https://github.com/apache/gravitino/pull/5376#discussion_r1823892708
##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalogPropertiesMetadata.java:
##########
@@ -128,13 +128,13 @@ public class PaimonCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetada
"Gravitino Paimon catalog jdbc user",
false /* immutable */,
null /* defaultValue */,
- true /* hidden */),
+ false /* hidden */),
Review Comment:
i checked the MysqlCatalog, PGCatalog, and tec. None of them tested whether
the jdbc user and password were hidden or not.
I think this pr can not include the test of this modification, but a new pr
can be created to specifically improve them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
