jerryshao commented on code in PR #5324:
URL: https://github.com/apache/gravitino/pull/5324#discussion_r1824058003
##########
docs/hadoop-catalog.md:
##########
@@ -44,46 +44,43 @@ Apart from the above properties, to access fileset like
HDFS, S3, GCS, OSS or cu
#### S3 fileset
-| Configuration item | Description
| Default value |
Required | Since version |
-|--------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------|----------------------------|------------------|
-| `filesystem-providers` | The file system providers to add. Set it to
`s3` if it's a s3 fileset or a comma separated string that contains `s3` like
`gs,s3` to support multiple kind of fileset including `s3`. | (none) |
Yes | 0.7.0-incubating |
-| `default-filesystem-provider` | The name default filesystem providers of
this Hadoop catalog if users do not specify the scheme in the URI. Default
value is `builtin-local`, for S3, if we set this value, we can omit the prefix
'oss://' in the location. | `builtin-local` | No |
0.7.0-incubating |
-| `s3-endpoint` | The endpoint of the AWS s3.
| (none) |
Yes if it's a s3 fileset. | 0.7.0-incubating |
-| `s3-access-key-id` | The access key of the AWS s3.
| (none) |
Yes if it's a s3 fileset. | 0.7.0-incubating |
-| `s3-secret-access-key` | The secret key of the AWS s3.
| (none) |
Yes if it's a s3 fileset. | 0.7.0-incubating |
-
-At the same time, you need to place the corresponding bundle jar
[gravitno-aws-bundle-{version}.jar](https://repo1.maven.org/maven2/org/apache/gravitino/aws-bundle/)
in the directory ${GRAVITINO_HOME}/catalogs/hadoop/libs.
+| Configuration item | Description
| Default value | Required | Since version
|
+|--------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------|---------------------------|------------------|
+| `filesystem-providers` | The file system providers to add. Set it to
`s3` if it's a s3 fileset, or a comma separated string that contains `s3` like
`gs,s3` to support multiple kinds of fileset including `s3`.
| (none) | Yes |
0.7.0-incubating |
+| `default-filesystem-provider` | The name default filesystem providers of
this Hadoop catalog if users do not specify the scheme in the URI. Default
value is `builtin-local`, for S3, if we set this value, we can omit the prefix
's3a://' in the location. | `builtin-local` | No |
0.7.0-incubating |
+| `s3-endpoint` | The endpoint of the AWS s3.
| (none) | Yes if it's a s3 fileset. |
0.7.0-incubating |
+| `s3-access-key-id` | The access key of the AWS s3.
| (none) | Yes if it's a s3 fileset. |
0.7.0-incubating |
+| `s3-secret-access-key` | The secret key of the AWS s3.
| (none) | Yes if it's a s3 fileset. |
0.7.0-incubating |
+At the same time, you need to place the corresponding bundle jar
[gravitino-aws-bundle-{version}.jar](https://repo1.maven.org/maven2/org/apache/gravitino/aws-bundle/)
in the directory ${GRAVITINO_HOME}/catalogs/hadoop/libs.
#### GCS fileset
| Configuration item | Description
| Default value | Required | Since version
|
|-------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------|----------------------------|------------------|
-| `filesystem-providers` | The file system providers to add. Set it to
`gs` if it's a gcs fileset or a comma separated string that contains `gs` like
`gs,s3` to support multiple kind of fileset including `gs`.
| (none) | Yes |
0.7.0-incubating |
+| `filesystem-providers` | The file system providers to add. Set it to
`gs` if it's a gcs fileset, a comma separated string that contains `gs` like
`gs,s3` to support multiple kinds of fileset including `gs`.
| (none) | Yes |
0.7.0-incubating |
Review Comment:
Sorry seems like the trailing whitespace is mainly for the table alignment,
right? If so, please keep them for the ease of review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
