shaofengshi commented on code in PR #5117:
URL: https://github.com/apache/gravitino/pull/5117#discussion_r1824120778


##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java:
##########
@@ -45,10 +58,26 @@ public Options options() {
     options.addOption(createSimpleOption("v", VERSION, "Gravitino client 
version"));
     options.addOption(createSimpleOption("r", SERVER, "Gravitino server 
version"));
     options.addOption(createArgOption("u", URL, "Gravitino URL (default: 
http://localhost:8090)"));
-    options.addOption(createArgOption("f", NAME, "full entity name (dot 
separated)"));
+    options.addOption(createArgOption("n", NAME, "full entity name (dot 
separated)"));
     options.addOption(createArgOption("m", METALAKE, "Metalake name"));
     options.addOption(createSimpleOption("i", IGNORE, "Ignore client/sever 
version check"));
 
+    // Create/update options
+    options.addOption(createArgOption("r", RENAME, "new entity name"));
+    options.addOption(createArgOption("c", COMMENT, "entity comment"));
+    options.addOption(createArgOption("p", PROPERTY, "property name"));
+    options.addOption(createArgOption("v", VALUE, "property value"));
+    options.addOption(
+        createArgOption(
+            "p", PROVIDER, "provider one of hadoop, hive, mysql, postgres, 
iceberg, kafka"));

Review Comment:
   The short-name of "p" has been occupied by "property" above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to