xunliu commented on code in PR #92: URL: https://github.com/apache/gravitino-playground/pull/92#discussion_r1825318097
########## install.sh: ########## @@ -0,0 +1,39 @@ +#!/bin/bash Review Comment: Please add the Apache license in the File head (First line). ``` #!/bin/bash # # Licensed to the Apache Software Foundation (ASF) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The ASF licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. # ``` ########## install.sh: ########## @@ -0,0 +1,39 @@ +#!/bin/bash + +# Check if Docker is installed +if ! command -v docker &> /dev/null +then + echo "Docker is not installed. Please install Docker before proceeding." + exit 1 +fi + +# Check if Docker Compose is installed +if ! command -v docker-compose &> /dev/null +then + echo "Docker Compose is not installed. Please install Docker Compose before proceeding." + exit 1 +fi Review Comment: I think we doesn't need check Docker and Docker compose in the here, because we already have check in the https://github.com/apache/gravitino-playground/blob/main/playground.sh#L26 So, Please remove these codes, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
