(gravitino) branch main updated: [#5306]Improvement(jdbc-catalog): make properties required (#5337)

[mchades]

This is an automated email from the ASF dual-hosted git repository.

mchades pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 28729a2af [#5306]Improvement(jdbc-catalog): make properties required 
(#5337)
28729a2af is described below

commit 28729a2af843361d8e0c2a7c45ebb12efd402479
Author: lsyulong <lsyul...@sina.com>
AuthorDate: Fri Nov 1 11:01:12 2024 +0800

    [#5306]Improvement(jdbc-catalog): make properties required (#5337)
    
    ### What changes were proposed in this pull request?
    
    Some JDBC catalog properties should be defined as required
    
    ### Why are the changes needed?
    
    Fix: #5306
    
    ### Does this PR introduce _any_ user-facing change?
    
    change some JDBC catalog properties
    
    ### How was this patch tested?
    No
---
 .../catalog/jdbc/JdbcCatalogPropertiesMetadata.java    | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git 
a/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
 
b/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
index f8b6d5e7a..d65bdfd7c 100644
--- 
a/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
+++ 
b/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
@@ -61,24 +61,30 @@ public class JdbcCatalogPropertiesMetadata extends 
BaseCatalogPropertiesMetadata
                 false /* immutable */,
                 null /* defaultValue */,
                 false /* hidden */),
-            stringOptionalPropertyEntry(
+            stringPropertyEntry(
                 JdbcConfig.JDBC_DRIVER.getKey(),
                 JdbcConfig.JDBC_DRIVER.getDoc(),
+                true /* required */,
                 false /* immutable */,
                 null /* defaultValue */,
-                false /* hidden */),
-            stringOptionalPropertyEntry(
+                false /* hidden */,
+                false /* reserved */),
+            stringPropertyEntry(
                 JdbcConfig.USERNAME.getKey(),
                 JdbcConfig.USERNAME.getDoc(),
+                true /* required */,
                 false /* immutable */,
                 null /* defaultValue */,
-                false /* hidden */),
-            stringOptionalPropertyEntry(
+                false /* hidden */,
+                false /* reserved */),
+            stringPropertyEntry(
                 JdbcConfig.PASSWORD.getKey(),
                 JdbcConfig.PASSWORD.getDoc(),
+                true /* required */,
                 false /* immutable */,
                 null /* defaultValue */,
-                false /* hidden */),
+                false /* hidden */,
+                false /* reserved */),
             integerPropertyEntry(
                 JdbcConfig.POOL_MIN_SIZE.getKey(),
                 JdbcConfig.POOL_MIN_SIZE.getDoc(),