This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch branch-0.7
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/branch-0.7 by this push:
new f5eba68e5 [#5306]Improvement(jdbc-catalog): make properties required
(#5411)
f5eba68e5 is described below
commit f5eba68e5905040739c1f1d12ebae541d5809d06
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Fri Nov 1 12:14:53 2024 +0800
[#5306]Improvement(jdbc-catalog): make properties required (#5411)
### What changes were proposed in this pull request?
Some JDBC catalog properties should be defined as required
### Why are the changes needed?
Fix: #5306
### Does this PR introduce _any_ user-facing change?
change some JDBC catalog properties
### How was this patch tested?
No
Co-authored-by: lsyulong <[email protected]>
---
.../catalog/jdbc/JdbcCatalogPropertiesMetadata.java | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git
a/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
b/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
index f8b6d5e7a..d65bdfd7c 100644
---
a/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
+++
b/catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java
@@ -61,24 +61,30 @@ public class JdbcCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetadata
false /* immutable */,
null /* defaultValue */,
false /* hidden */),
- stringOptionalPropertyEntry(
+ stringPropertyEntry(
JdbcConfig.JDBC_DRIVER.getKey(),
JdbcConfig.JDBC_DRIVER.getDoc(),
+ true /* required */,
false /* immutable */,
null /* defaultValue */,
- false /* hidden */),
- stringOptionalPropertyEntry(
+ false /* hidden */,
+ false /* reserved */),
+ stringPropertyEntry(
JdbcConfig.USERNAME.getKey(),
JdbcConfig.USERNAME.getDoc(),
+ true /* required */,
false /* immutable */,
null /* defaultValue */,
- false /* hidden */),
- stringOptionalPropertyEntry(
+ false /* hidden */,
+ false /* reserved */),
+ stringPropertyEntry(
JdbcConfig.PASSWORD.getKey(),
JdbcConfig.PASSWORD.getDoc(),
+ true /* required */,
false /* immutable */,
null /* defaultValue */,
- false /* hidden */),
+ false /* hidden */,
+ false /* reserved */),
integerPropertyEntry(
JdbcConfig.POOL_MIN_SIZE.getKey(),
JdbcConfig.POOL_MIN_SIZE.getDoc(),