yuqi1129 commented on code in PR #5426:
URL: https://github.com/apache/gravitino/pull/5426#discussion_r1827160007
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/CatalogMetaService.java:
##########
@@ -242,16 +251,28 @@ public boolean deleteCatalog(NameIdentifier identifier,
boolean cascade) {
"Entity %s has sub-entities, you should remove sub-entities
first", identifier);
}
SessionUtils.doMultipleWithCommit(
- () ->
- SessionUtils.doWithoutCommit(
- CatalogMetaMapper.class,
- mapper ->
mapper.softDeleteCatalogMetasByCatalogId(catalogId)),
() ->
SessionUtils.doWithoutCommit(
OwnerMetaMapper.class,
mapper ->
mapper.softDeleteOwnerRelByMetadataObjectIdAndType(
- catalogId, MetadataObject.Type.CATALOG.name())));
+ catalogId, MetadataObject.Type.CATALOG.name())),
+ () ->
+ SessionUtils.doWithoutCommit(
+ SecurableObjectMapper.class,
+ mapper ->
+ mapper.softDeleteObjectRelsByMetadataObject(
+ catalogId, MetadataObject.Type.CATALOG.name())),
+ () ->
+ SessionUtils.doWithoutCommit(
+ TagMetadataObjectRelMapper.class,
+ mapper ->
+ mapper.softDeleteTagMetadataObjectRelsByMetadataObject(
+ catalogId, MetadataObject.Type.CATALOG.name())),
+ () ->
+ SessionUtils.doWithoutCommit(
+ CatalogMetaMapper.class,
+ mapper ->
mapper.softDeleteCatalogMetasByCatalogId(catalogId)));
Review Comment:
Does the deletion sequence of `securableobject`, `tag` and `catalog` matters
in this transaction? why do you change the sequence of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
