This is an automated email from the ASF dual-hosted git repository.

jshao pushed a commit to branch branch-0.7
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/branch-0.7 by this push:
     new 661c5c997 [Minor] fix(docs): Fix mistakes in docs about the example of 
S3 fileset. (#5466)
661c5c997 is described below

commit 661c5c997e8c43b482d933346d42496e55d4d71d
Author: github-actions[bot] 
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Tue Nov 5 17:55:45 2024 +0800

    [Minor] fix(docs): Fix mistakes in docs about the example of S3 fileset. 
(#5466)
    
    ### What changes were proposed in this pull request?
    
    Fix s3 fileset example that uses "oss:/" prefix mistakenly.
    
    ### Why are the changes needed?
    
    It's a mistake.
    
    ### Does this PR introduce _any_ user-facing change?
    
    N/A.
    
    ### How was this patch tested?
    
    N/A
    
    Co-authored-by: Qi Yu <[email protected]>
---
 docs/how-to-use-gvfs.md                         |  8 ++++----
 docs/manage-fileset-metadata-using-gravitino.md | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/docs/how-to-use-gvfs.md b/docs/how-to-use-gvfs.md
index 4c1c5b943..7a3373092 100644
--- a/docs/how-to-use-gvfs.md
+++ b/docs/how-to-use-gvfs.md
@@ -83,10 +83,10 @@ At the same time, you need to place the corresponding 
bundle jar [`gravitino-aws
 
 #### GCS fileset
 
-| Configuration item             | Description                                 
                                                                                
                                                             | Default value | 
Required                  | Since version      |
-|--------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|---------------------------|--------------------|
-| `fs.gvfs.filesystem.providers` | The file system providers to add. Set it to 
`gs` if it's a GCS fileset, or a comma separated string that contains `gs` like 
`gs,s3` to support multiple kinds of fileset including `gs`. | (none)        | 
Yes if it's a GCS fileset.|   0.7.0-incubating |
-| `gcs-service-account-file`     | The path of GCS service account JSON file.  
                                                                                
                                                             | (none)        | 
Yes if it's a GCS fileset.| 0.7.0-incubating   |
+| Configuration item             | Description                                 
                                                                                
                                                             | Default value | 
Required                  | Since version    |
+|--------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------|---------------------------|------------------|
+| `fs.gvfs.filesystem.providers` | The file system providers to add. Set it to 
`gs` if it's a GCS fileset, or a comma separated string that contains `gs` like 
`gs,s3` to support multiple kinds of fileset including `gs`. | (none)        | 
Yes if it's a GCS fileset.| 0.7.0-incubating |
+| `gcs-service-account-file`     | The path of GCS service account JSON file.  
                                                                                
                                                             | (none)        | 
Yes if it's a GCS fileset.| 0.7.0-incubating |
 
 In the meantime, you need to place the corresponding bundle jar 
[`gravitino-gcp-bundle-${version}.jar`](https://repo1.maven.org/maven2/org/apache/gravitino/gcp-bundle/)
 in the Hadoop environment(typically located in 
`${HADOOP_HOME}/share/hadoop/common/lib/`).
 
diff --git a/docs/manage-fileset-metadata-using-gravitino.md 
b/docs/manage-fileset-metadata-using-gravitino.md
index b6ba3ed2e..a3ab73b9c 100644
--- a/docs/manage-fileset-metadata-using-gravitino.md
+++ b/docs/manage-fileset-metadata-using-gravitino.md
@@ -61,10 +61,10 @@ curl -X POST -H "Accept: application/vnd.gravitino.v1+json" 
\
   "comment": "comment",
   "provider": "hadoop",
   "properties": {
-    "location": "oss:/bucket/root",
+    "location": "s3a://bucket/root",
     "s3-access-key-id": "access_key",
     "s3-secret-access-key": "secret_key",
-    "s3-endpoint": "http://oss-cn-hangzhou.aliyuncs.com";,
+    "s3-endpoint": "http://s3.ap-northeast-1.amazonaws.com";,
     "filesystem-providers": "s3"
   }
 }' http://localhost:8090/api/metalakes/metalake/catalogs
@@ -93,10 +93,10 @@ Catalog catalog = gravitinoClient.createCatalog("catalog",
 
 // create a S3 catalog
 s3Properties = ImmutableMap.<String, String>builder()
-    .put("location", "oss:/bucket/root")
+    .put("location", "s3a://bucket/root")
     .put("s3-access-key-id", "access_key")
     .put("s3-secret-access-key", "secret_key")
-    .put("s3-endpoint", "http://oss-cn-hangzhou.aliyuncs.com";)
+    .put("s3-endpoint", "http://s3.ap-northeast-1.amazonaws.com";)
     .put("filesystem-providers", "s3")
     .build();
 
@@ -121,10 +121,10 @@ catalog = gravitino_client.create_catalog(name="catalog",
 
 # create a S3 catalog
 s3_properties = {
-    "location": "oss:/bucket/root",
+    "location": "s3a://bucket/root",
     "s3-access-key-id": "access_key"
     "s3-secret-access-key": "secret_key",
-    "s3-endpoint": "http://oss-cn-hangzhou.aliyuncs.com";
+    "s3-endpoint": "http://s3.ap-northeast-1.amazonaws.com";
 }
 
 s3_catalog = gravitino_client.create_catalog(name="catalog",

Reply via email to