jerryshao commented on code in PR #5350:
URL: https://github.com/apache/gravitino/pull/5350#discussion_r1832187745
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java:
##########
@@ -67,8 +67,12 @@ public void handle() {
String name = columns[i].name();
String dataType = columns[i].dataType().simpleString();
String comment = columns[i].comment();
- String nullable = columns[i].nullable() ? "null" : "";
- String autoIncrement = columns[i].autoIncrement() ? "auto" : "";
+ String nullable = columns[i].nullable() ? "true" : "false";
+ String autoIncrement = columns[i].autoIncrement() ? "true" : "false";
+
+ if (i == 0) {
+ all.append("name,datatype,comment,nullable,auto" +
System.lineSeparator());
+ }
Review Comment:
1) I think you can move this line above, out of "for loop", so you don't
have to check if `i == 0`;
2) It is better to change "auto" to "auto_increment" for better
understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
