shaofengshi commented on code in PR #5133:
URL: https://github.com/apache/gravitino/pull/5133#discussion_r1832509429
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java:
##########
@@ -64,12 +66,13 @@ public Options options() {
options.addOption(createArgOption("V", VALUE, "property value"));
options.addOption(
createArgOption(
- "g", PROVIDER, "provider one of hadoop, hive, mysql, postgres,
iceberg, kafka"));
+ "t", PROVIDER, "provider one of hadoop, hive, mysql, postgres,
iceberg, kafka"));
+ options.addOption(createArgOption("l", USER, "user name"));
+ options.addOption(createArgOption("g", GROUP, "group name"));
// Properties option can have multiple values
Option properties =
- createArgOption("p", PROPERTIES, "comma separated property name/value
pairs");
- properties.hasArgs();
+ Option.builder("p").longOpt(PROPERTIES).desc("property name/value
pairs").hasArgs().build();
Review Comment:
"comma separated" is a necessary description for the properties I think, why
not keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
