justinmclean commented on code in PR #5476: URL: https://github.com/apache/gravitino/pull/5476#discussion_r1833781180
########## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListIndexes.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.cli.commands; + +import java.util.ArrayList; +import java.util.List; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.rel.indexes.Index; + +/** Displays the index of a table. */ +public class ListIndexes extends TableCommand { + + protected final String schema; + protected final String table; + + /** + * Displays the index of a table. + * + * @param url The URL of the Gravitino server. + * @param ignoreVersions If true don't check the client/server versions match. + * @param metalake The name of the metalake. + * @param catalog The name of the catalog. + * @param schema The name of the schema. + * @param table The name of the table. + */ + public ListIndexes( + String url, + boolean ignoreVersions, + String metalake, + String catalog, + String schema, + String table) { + super(url, ignoreVersions, metalake, catalog); + this.schema = schema; + this.table = table; + } + + /** Displays the details of a table's index. */ + public void handle() { + Index[] indexes; + + try { + NameIdentifier name = NameIdentifier.of(schema, table); + indexes = tableCatalog().loadTable(name).index(); + } catch (Exception exp) { + System.err.println(exp.getMessage()); + return; + } + + StringBuilder all = new StringBuilder(); + for (Index index : indexes) { + // Flatten the two-dimensional array fieldNames to a single dot-separated string + List<String> flattenedFieldNames = new ArrayList<>(); + for (String[] fieldHierarchy : index.fieldNames()) { + // Join nested fields (e.g., "a.b.c") for each inner array + flattenedFieldNames.add(String.join(".", fieldHierarchy)); + } Review Comment: I think this code could be simpler; also, in most scenarios, the field names are single-level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
