puchengy commented on code in PR #5495:
URL: https://github.com/apache/gravitino/pull/5495#discussion_r1834750272
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergRequestContext.java:
##########
@@ -19,16 +19,23 @@
package org.apache.gravitino.iceberg.service;
+import java.util.Map;
import javax.servlet.http.HttpServletRequest;
import lombok.Getter;
+import org.apache.gravitino.utils.PrincipalUtils;
/** The general request context information for Iceberg REST operations. */
public class IcebergRequestContext {
- @Getter private final HttpServletRequest httpRequest;
+
@Getter private final String catalogName;
+ @Getter private final String userName;
+ @Getter private final String remoteIp;
Review Comment:
May I ask if we can add remoteHostName as well?
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergTableOperations.java:
##########
@@ -269,6 +269,10 @@ public Response reportTableMetrics(
return IcebergRestUtils.noContent();
}
+ HttpServletRequest httpServletRequest() {
Review Comment:
Curious why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
