orenccl commented on code in PR #103:
URL:
https://github.com/apache/gravitino-playground/pull/103#discussion_r1835718785
##########
playground.sh:
##########
@@ -64,140 +127,277 @@ checkHelm() {
if [ $isExist ]; then
true # Placeholder, do nothing
else
- echo "ERROR: Helm command not found, Please install helm v3."
+ echo "[ERROR] Helm check failed: Helm command not found, Please install
helm v3."
exit
fi
# check version
# version will be like:
# Version:"v3.15.2"
regex="Version:\"(v[0-9]\.[0-9]+\.[0-9])\""
version=$(helm version)
Review Comment:
This section checks if Helm exists:
```bash
isExist=$(command -v helm)
if [ "$isExist" ]; then
```
I've unified the usage of `which` and `command -v` to use `command -v` for
consistent style.
```bash
if command -v helm >/dev/null 2>&1; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
