FANNG1 commented on code in PR #5495:
URL: https://github.com/apache/gravitino/pull/5495#discussion_r1835914554
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergRequestContext.java:
##########
@@ -19,16 +19,23 @@
package org.apache.gravitino.iceberg.service;
+import java.util.Map;
import javax.servlet.http.HttpServletRequest;
import lombok.Getter;
+import org.apache.gravitino.utils.PrincipalUtils;
/** The general request context information for Iceberg REST operations. */
public class IcebergRequestContext {
- @Getter private final HttpServletRequest httpRequest;
+
@Getter private final String catalogName;
+ @Getter private final String userName;
+ @Getter private final String remoteIp;
Review Comment:
updated with `remoteHostName`, because it's more user friendly, if it has
some performance decrease for resolving hostname, let's change to `remoteIP`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
