justinmclean commented on code in PR #5291: URL: https://github.com/apache/gravitino/pull/5291#discussion_r1835930555
########## docs/cli.md: ########## @@ -247,99 +255,99 @@ The type of catalog to be created is specified by the `--provider` option. Diffe ##### Create a Hive catalog ```bash -gcli catalog create --metalake metalake_demo --name hive --provider hive --properties metastore.uris=thrift://hive-host:9083 +gcli catalog create --name hive --provider hive --properties metastore.uris=thrift://hive-host:9083 ``` ##### Create an Iceberg catalog ```bash -gcli catalog create --metalake metalake_demo -name iceberg --provider iceberg --properties uri=thrift://hive-host:9083,catalog-backend=hive,warehouse=hdfs://hdfs-host:9000/user/iceberg/warehouse +gcli catalog create -name iceberg --provider iceberg --properties uri=thrift://hive-host:9083,catalog-backend=hive,warehouse=hdfs://hdfs-host:9000/user/iceberg/warehouse ``` ##### Create a MySQL catalog ```bash -gcli catalog create --metalake metalake_demo -name mysql --provider mysql --properties jdbc-url=jdbc:mysql://mysql-host:3306?useSSL=false,jdbc-user=user,jdbc-password=password,jdbc-driver=com.mysql.cj.jdbc.Driver +gcli catalog create -name mysql --provider mysql --properties jdbc-url=jdbc:mysql://mysql-host:3306?useSSL=false,jdbc-user=user,jdbc-password=password,jdbc-driver=com.mysql.cj.jdbc.Driver ``` ##### Create a Postgres catalog ```bash -gcli catalog create --metalake metalake_demo -name postgres --provider postgres --properties jdbc-url=jdbc:postgresql://postgresql-host/mydb,jdbc-user=user,jdbc-password=password,jdbc-database=db,jdbc-driver=org.postgresql.Driver +gcli catalog create -name postgres --provider postgres --properties jdbc-url=jdbc:postgresql://postgresql-host/mydb,jdbc-user=user,jdbc-password=password,jdbc-database=db,jdbc-driver=org.postgresql.Driver ``` ##### Create a Kafka catalog ```bash -gcli catalog create --metalake metalake_demo -name kafka --provider kafka --properties bootstrap.servers=127.0.0.1:9092,127.0.0.2:9092 +gcli catalog create --name kafka --provider kafka --properties bootstrap.servers=127.0.0.1:9092,127.0.0.2:9092 ``` #### Delete a catalog ```bash -gcli catalog delete --metalake metalake_demo --name hive +gcli catalog delete --name hive ``` #### Rename a catalog ```bash -gcli catalog update --metalake metalake_demo --name catalog_mysql --rename mysql +gcli catalog update --name catalog_mysql --rename mysql Review Comment: I also note this has nothing to do with this PR. If it is a new issue, it would be best to raise it and deal with it in another PR, I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
