jerryshao commented on code in PR #5521:
URL: https://github.com/apache/gravitino/pull/5521#discussion_r1836076871
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##########
@@ -581,29 +583,63 @@ public Schema alterSchema(NameIdentifier ident,
SchemaChange... changes)
@Override
public boolean dropSchema(NameIdentifier ident, boolean cascade) throws
NonEmptySchemaException {
try {
+ Namespace filesetNs =
+ Namespace.of(
+ Stream.concat(Stream.of(ident.namespace().levels()),
Stream.of(ident.name()))
+ .toArray(String[]::new));
+ List<FilesetEntity> filesets =
+ store.list(filesetNs, FilesetEntity.class,
Entity.EntityType.FILESET);
Review Comment:
I think it should return false, not throwing an exception, according the API
definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
