justinmclean commented on code in PR #5525: URL: https://github.com/apache/gravitino/pull/5525#discussion_r1837576205
########## docs/cli.md: ########## @@ -352,7 +352,11 @@ gcli column list --metalake metalake_demo --name catalog_postgres.hr.departments ```bash gcli table details --metalake metalake_demo --name catalog_postgres.hr.departments --audit ``` +#### Show tables distribution information +```bash +gcli table details --metalake metalake_demo --name catalog_postgres.hr.departments --distribution +``` Review Comment: Added an `--extended` or similar option (`--all` would perhaps be a better name?) would not solve the backwards/forward compatibility issue and limits flexibility. Users might want specific details rather than everything in the "extended" or "all" output, especially if they’re scripting and only need one or two specific pieces of information. We could add an --extended/--all for quick, high-level use, showing all additional details, but we also offer optional, specific flags like --audit, --distribution, and --index. This way users who need fine control can selectively display only what they need, while casual users can rely on --extended/--all to see more information. This approach minimises the risk of breaking user scripts in the future if new fields are added. Filesets and topics are entities, new entities, in general, would not require any extra flags. The current design doc and existing PR topics do add a topic flag, but combining it with the name flag would be possible. Currently, Fileset has some flags as part of the fileset creation, but they will be removed and become properties. So we can avoid adding extra flags for these entities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
