SZL741023 commented on code in PR #5567:
URL: https://github.com/apache/gravitino/pull/5567#discussion_r1842399178
##########
web/web/src/app/rootLayout/AppBar.js:
##########
@@ -56,14 +66,31 @@ const AppBar = () => {
const [metalakes, setMetalakes] = useState([])
const router = useRouter()
const logoSrc = (process.env.NEXT_PUBLIC_BASE_PATH ?? '') +
'/icons/gravitino.svg'
+ const username = 'apache'
+ const repository = 'gravitino'
+ const [githubData, setGithubData] = useState({ stars: 0, forks: 0 })
useEffect(() => {
+ const fetchGitHubData = async () => {
+ try {
+ const response = await
axios.get(`https://api.github.com/repos/${username}/${repository}`)
+ let { stargazers_count, forks_count } = response.data
Review Comment:
Hi @LauraXia123,
Thanks for suggestion.
I have some question for you.
1. The format filter function that you mean is like image below?
2. How to use defHttp to get GitHub API, I use ```const response =
defHttp.get({url: githubAIP})```, but always response AxiosError, what's wrong
with my code?
3. How can I get the svgs in ```/gravitino/web/web/src/lib/icons/svg/``` or
this folder is only for ```pnpm gen:icons```, after add apache license, I need
to move svg to ```/pubilc/icons/```?
4. Why do you suggest me to add overrideSrc, I use this keyword to search
information, but I can't find anything. what does this attribute means?
thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
