justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1846132354
########## docs/cli.md: ########## @@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag gcli tag update --tag tagA --comment "new comment" ``` +### Owners commands + +#### List an owner + +```bash +gcli catalog details --name postgres --owner +``` + +#### Set an owner to a user + +```bash +gcli catalog set --name postgres --user admin Review Comment: `set-owner` doesn't align with that advice as it's inconsistent with the verbs used for different types of objects. i.e. you are using different verbs for different objects. Also, in this case, more sub-commands mean that the code needs to be duplicated for every entity rather than working off a single flag. Having a single flag means it will be future-proof, as if new entities are added as no new code is needed, while using a command will mean new code will need to be added for each new entity added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
