This is an automated email from the ASF dual-hosted git repository.

shaofengshi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 092f58a92 [Minor] improvement to Partition Gravitino CLI code (#5617)
092f58a92 is described below

commit 092f58a92893e31725357519053e1a676cc04ec5
Author: Justin Mclean <[email protected]>
AuthorDate: Wed Nov 20 18:08:28 2024 +1100

    [Minor] improvement to Partition Gravitino CLI code (#5617)
    
    ### What changes were proposed in this pull request?
    
    Minor improvements to Partition Gravitino CLI code.
    
    ### Why are the changes needed?
    
    Remove duplicate short command code and make the same style as other
    options.
    
    Fix: # N/A
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Tested locally
---
 .../src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java  | 2 +-
 .../cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java 
b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
index 0ba4046d2..b52aec133 100644
--- 
a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
+++ 
b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
@@ -356,7 +356,7 @@ public class GravitinoCommandLine {
         new ListIndexes(url, ignore, metalake, catalog, schema, 
table).handle();
       } else if (line.hasOption(GravitinoOptions.DISTRIBUTION)) {
         new TableDistribution(url, ignore, metalake, catalog, schema, 
table).handle();
-      } else if (line.hasOption(GravitinoOptions.Partition)) {
+      } else if (line.hasOption(GravitinoOptions.PARTITION)) {
         new TablePartition(url, ignore, metalake, catalog, schema, 
table).handle();
       } else {
         new TableDetails(url, ignore, metalake, catalog, schema, 
table).handle();
diff --git 
a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java 
b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
index 12812190d..a6afdd589 100644
--- a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
+++ b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
@@ -45,7 +45,7 @@ public class GravitinoOptions {
   public static final String INDEX = "index";
   public static final String FORCE = "force";
   public static final String DISTRIBUTION = "distribution";
-  public static final String Partition = "partition";
+  public static final String PARTITION = "partition";
 
   /**
    * Builds and returns the CLI options for Gravitino.
@@ -66,7 +66,7 @@ public class GravitinoOptions {
     options.addOption(createSimpleOption("a", AUDIT, "display audit 
information"));
     options.addOption(createSimpleOption("x", INDEX, "Display index 
infromation"));
     options.addOption(createSimpleOption("d", DISTRIBUTION, "Display 
distribution information"));
-    options.addOption(createSimpleOption("p", Partition, "Display partition 
information"));
+    options.addOption(createSimpleOption(null, PARTITION, "Display partition 
information"));
 
     // Create/update options
     options.addOption(createArgOption(null, RENAME, "new entity name"));

Reply via email to