tengqm commented on code in PR #5638:
URL: https://github.com/apache/gravitino/pull/5638#discussion_r1851177312
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -554,4 +554,51 @@ public String getUrl() {
// Return the default localhost URL
return DEFAULT_URL;
}
+
+ /* Methods used for testing - basically a seam where we can see what it
passed and use mocks to see if the correct command is created. */
+
+ protected MetalakeAudit createMetalakeAudit(String url, boolean ignore,
String metalake) {
+ return new MetalakeAudit(url, ignore, metalake);
+ }
+
+ protected MetalakeDetails createMetalakeDetails(String url, boolean ignore,
String metalake) {
+ return new MetalakeDetails(url, ignore, metalake);
+ }
+
+ protected ListMetalakes createListMetalakes(String url, boolean ignore) {
+ return new ListMetalakes(url, ignore);
+ }
+
+ CreateMetalake createCreateMetalake(String url, boolean ignore, String
metalake, String comment) {
Review Comment:
Function name is a little bit awkward ...
Maybe change these methods to "newXYZ"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
