tengqm commented on code in PR #5636:
URL: https://github.com/apache/gravitino/pull/5636#discussion_r1851221041
##########
web/web/src/lib/utils/initial.js:
##########
@@ -467,7 +449,132 @@ export const tableColumnTypes = [
valid: true
}
}
- },
- { key: 'uuid' },
- { key: 'binary' }
-]
+ }
+}
+
+export const getParameterizedColumnType = type => {
+ if (Object.keys(parameterizedColumnTypes).includes(type)) {
+ return parameterizedColumnTypes[type]
+ }
+}
+
+const relationalColumnTypeMap = {
+ 'lakehouse-iceberg': [
+ 'boolean',
+ 'integer',
+ 'long',
+ 'float',
+ 'double',
+ 'string',
+ 'date',
+ 'time',
+ 'timestamp',
+ 'timestamp_tz',
+ 'decimal',
+ 'fixed',
+ 'binary',
+ 'uuid'
Review Comment:
Yup. I'd suggest we sort the list alphabetically if possible (not breaking
anything).
Ordered lists have a better maintainability and readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
