tengqm commented on code in PR #5651: URL: https://github.com/apache/gravitino/pull/5651#discussion_r1853725507
########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java: ########## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.iceberg.service.dispatcher; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.iceberg.service.IcebergRestUtils; +import org.apache.gravitino.listener.EventBus; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesPreEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsPreEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTableEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTableFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTablePreEvent; +import org.apache.gravitino.listener.api.event.IcebergRequestContext; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespacePreEvent; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.rest.requests.CreateNamespaceRequest; +import org.apache.iceberg.rest.requests.RegisterTableRequest; +import org.apache.iceberg.rest.requests.UpdateNamespacePropertiesRequest; +import org.apache.iceberg.rest.responses.CreateNamespaceResponse; +import org.apache.iceberg.rest.responses.GetNamespaceResponse; +import org.apache.iceberg.rest.responses.ListNamespacesResponse; +import org.apache.iceberg.rest.responses.LoadTableResponse; +import org.apache.iceberg.rest.responses.UpdateNamespacePropertiesResponse; + +/** + * {@code IcebergNamespaceEventDispatcher} is a decorator for {@link + * IcebergNamespaceOperationExecutor} that not only delegates namespace operations to the underlying + * dispatcher but also dispatches corresponding events to an {@link EventBus}. + */ +public class IcebergNamespaceEventDispatcher implements IcebergNamespaceOperationDispatcher { + + private IcebergNamespaceOperationDispatcher icebergNamespaceOperationDispatcher; Review Comment: Why don't we name this as, like `dispatcher`, given that it is just a private attribute. ########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java: ########## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.iceberg.service.dispatcher; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.iceberg.service.IcebergRestUtils; +import org.apache.gravitino.listener.EventBus; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesPreEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsPreEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTableEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTableFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTablePreEvent; +import org.apache.gravitino.listener.api.event.IcebergRequestContext; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespacePreEvent; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.rest.requests.CreateNamespaceRequest; +import org.apache.iceberg.rest.requests.RegisterTableRequest; +import org.apache.iceberg.rest.requests.UpdateNamespacePropertiesRequest; +import org.apache.iceberg.rest.responses.CreateNamespaceResponse; +import org.apache.iceberg.rest.responses.GetNamespaceResponse; +import org.apache.iceberg.rest.responses.ListNamespacesResponse; +import org.apache.iceberg.rest.responses.LoadTableResponse; +import org.apache.iceberg.rest.responses.UpdateNamespacePropertiesResponse; + +/** + * {@code IcebergNamespaceEventDispatcher} is a decorator for {@link + * IcebergNamespaceOperationExecutor} that not only delegates namespace operations to the underlying + * dispatcher but also dispatches corresponding events to an {@link EventBus}. + */ +public class IcebergNamespaceEventDispatcher implements IcebergNamespaceOperationDispatcher { + + private IcebergNamespaceOperationDispatcher icebergNamespaceOperationDispatcher; + private EventBus eventBus; + private String metalakeName; + + public IcebergNamespaceEventDispatcher( + IcebergNamespaceOperationDispatcher icebergNamespaceOperationDispatcher, + EventBus eventBus, + String metalakeName) { + this.icebergNamespaceOperationDispatcher = icebergNamespaceOperationDispatcher; + this.eventBus = eventBus; + this.metalakeName = metalakeName; + } + + @Override + public CreateNamespaceResponse createNamespace( + IcebergRequestContext context, CreateNamespaceRequest createNamespaceRequest) { Review Comment: ```suggestion IcebergRequestContext context, CreateNamespaceRequest request) { ``` ########## iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergNamespaceEventDispatcher.java: ########## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.iceberg.service.dispatcher; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.iceberg.service.IcebergRestUtils; +import org.apache.gravitino.listener.EventBus; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergCreateNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergDropNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergListNamespacesPreEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergLoadNamespacePreEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergNamespaceExistsPreEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTableEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTableFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergRegisterTablePreEvent; +import org.apache.gravitino.listener.api.event.IcebergRequestContext; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespaceEvent; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespaceFailureEvent; +import org.apache.gravitino.listener.api.event.IcebergUpdateNamespacePreEvent; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.rest.requests.CreateNamespaceRequest; +import org.apache.iceberg.rest.requests.RegisterTableRequest; +import org.apache.iceberg.rest.requests.UpdateNamespacePropertiesRequest; +import org.apache.iceberg.rest.responses.CreateNamespaceResponse; +import org.apache.iceberg.rest.responses.GetNamespaceResponse; +import org.apache.iceberg.rest.responses.ListNamespacesResponse; +import org.apache.iceberg.rest.responses.LoadTableResponse; +import org.apache.iceberg.rest.responses.UpdateNamespacePropertiesResponse; + +/** + * {@code IcebergNamespaceEventDispatcher} is a decorator for {@link + * IcebergNamespaceOperationExecutor} that not only delegates namespace operations to the underlying + * dispatcher but also dispatches corresponding events to an {@link EventBus}. + */ +public class IcebergNamespaceEventDispatcher implements IcebergNamespaceOperationDispatcher { + + private IcebergNamespaceOperationDispatcher icebergNamespaceOperationDispatcher; + private EventBus eventBus; + private String metalakeName; + + public IcebergNamespaceEventDispatcher( + IcebergNamespaceOperationDispatcher icebergNamespaceOperationDispatcher, + EventBus eventBus, + String metalakeName) { + this.icebergNamespaceOperationDispatcher = icebergNamespaceOperationDispatcher; + this.eventBus = eventBus; + this.metalakeName = metalakeName; + } + + @Override + public CreateNamespaceResponse createNamespace( + IcebergRequestContext context, CreateNamespaceRequest createNamespaceRequest) { + NameIdentifier nameIdentifier = + IcebergRestUtils.getGravitinoNameIdentifier( + metalakeName, context.catalogName(), createNamespaceRequest.namespace()); + + eventBus.dispatchEvent( + new IcebergCreateNamespacePreEvent(context, nameIdentifier, createNamespaceRequest)); + + CreateNamespaceResponse createNamespaceResponse; + try { + createNamespaceResponse = + icebergNamespaceOperationDispatcher.createNamespace(context, createNamespaceRequest); Review Comment: If we use shorter names, this code could be revised to something like this: ```java response = dispatcher.createNamespace(context, request); ``` I'm not asking for renaming this further, like: ```suggestion resp = dispatcher.createNamespace(ctx, req); ``` The code is to be understood and maintained by people at the end of day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
