xunliu commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1856499732
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/MetalakeDetails.java:
##########
@@ -33,27 +34,24 @@ public class MetalakeDetails extends Command {
* @param url The URL of the Gravitino server.
* @param ignoreVersions If true don't check the client/server versions
match.
* @param metalake The name of the metalake.
+ * @param OutputFormat The output format.
*/
- public MetalakeDetails(String url, boolean ignoreVersions, String metalake) {
- super(url, ignoreVersions);
+ public MetalakeDetails(String url, boolean ignoreVersions, String metalake,
String OutputFormat) {
+ super(url, ignoreVersions, OutputFormat);
Review Comment:
DONE
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/MetalakeDetails.java:
##########
@@ -33,27 +34,24 @@ public class MetalakeDetails extends Command {
* @param url The URL of the Gravitino server.
* @param ignoreVersions If true don't check the client/server versions
match.
* @param metalake The name of the metalake.
+ * @param OutputFormat The output format.
Review Comment:
DONE
##########
clients/cli/src/test/java/org/apache/gravitino/cli/TestMetalakeCommands.java:
##########
@@ -59,7 +59,9 @@ void testListMetalakesCommand() {
spy(
new GravitinoCommandLine(
mockCommandLine, mockOptions, CommandEntities.METALAKE,
CommandActions.LIST));
-
doReturn(mockList).when(commandLine).newListMetalakes(GravitinoCommandLine.DEFAULT_URL,
false);
+ doReturn(mockList)
+ .when(commandLine)
+ .newListMetalakes(GravitinoCommandLine.DEFAULT_URL, false, "");
Review Comment:
DONE
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java:
##########
@@ -89,6 +89,7 @@ public Options options() {
// Force delete entity and rename metalake operations
options.addOption(createSimpleOption("f", FORCE, "force operation"));
+ options.addOption(createArgOption(null, OUTPUT, "output format (table)"));
Review Comment:
DONE
##########
clients/cli/src/test/java/org/apache/gravitino/cli/TestMetalakeCommands.java:
##########
@@ -76,7 +78,7 @@ void testMetalakeDetailsCommand() {
mockCommandLine, mockOptions, CommandEntities.METALAKE,
CommandActions.DETAILS));
doReturn(mockDetails)
.when(commandLine)
- .newMetalakeDetails(GravitinoCommandLine.DEFAULT_URL, false,
"metalake_demo");
+ .newMetalakeDetails(GravitinoCommandLine.DEFAULT_URL, false,
"metalake_demo", "");
Review Comment:
DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
